Skip to content

[Dashboard] Fix: Only use paymaster for sophon testnet chain #5392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2024
Merged

[Dashboard] Fix: Only use paymaster for sophon testnet chain #5392

merged 1 commit into from
Nov 13, 2024

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Nov 12, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on modifying the handling of transactions for the sophon testnet, specifically for zk chains. It introduces a special condition to always use EIP-712 transactions with a paymaster for this network.

Detailed summary

  • Removed old logic for handling zk chains on testnets.
  • Introduced a specific check for the sophon testnet (chain ID 531050104).
  • Ensured that EIP-712 transactions are always used with a paymaster for the sophon testnet.
  • Streamlined the process of retrieving paymaster data for transactions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 8:38pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 13, 2024 8:38pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 13, 2024 8:38pm
wallet-ui ⬜️ Skipped (Inspect) Nov 13, 2024 8:38pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 12, 2024 15:50 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7bbe60f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 12, 2024 15:50 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 12, 2024 15:50 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review November 12, 2024 15:50
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 12, 2024
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Nov 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.52%. Comparing base (9f9b67d) to head (7bbe60f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5392   +/-   ##
=======================================
  Coverage   45.52%   45.52%           
=======================================
  Files        1070     1070           
  Lines       55665    55665           
  Branches     4030     4030           
=======================================
  Hits        25341    25341           
  Misses      29637    29637           
  Partials      687      687
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9f9b67d
packages 40.62% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.8 KB (0%) 896 ms (0%) 303 ms (+27.48% 🔺) 1.2 s
thirdweb (cjs) 105.11 KB (0%) 2.2 s (0%) 522 ms (-10.14% 🔽) 2.7 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 33 ms (+46.39% 🔺) 148 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 40 ms (+313.49% 🔺) 50 ms
thirdweb/react (minimal + tree-shaking) 18.78 KB (0%) 376 ms (0%) 76 ms (+22.67% 🔺) 452 ms

@gregfromstl gregfromstl changed the title fix: only use paymaster for sophon testnet chain [Dashboard] Fix: Only use paymaster for sophon testnet chain Nov 13, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 13, 2024 •
edited
Loading

Merge activity

@joaquim-verges
[Dashboard] Fix: Only use paymaster for sophon testnet chain (#5392)
7bbe60f 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the handling of transactions for the `sophon` testnet, specifically for zk chains. It introduces a special case for transactions that ensures the use of an EIP-712 transaction format along with a paymaster.

### Detailed summary
- Removed the general check for zk chains on testnets.
- Added a specific condition for the `sophon` testnet (chain ID `531050104`).
- Ensured that transactions on the `sophon` testnet always use EIP-712 format and include paymaster data.
- Simplified the transaction handling by removing unnecessary error handling logic.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the fix_only_use_paymaster_for_sophon_testnet_chain branch from 9f37e4a to 7bbe60f Compare November 13, 2024 20:29
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 13, 2024 20:29 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 13, 2024 20:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 13, 2024 20:29 Inactive
@graphite-app graphite-app bot merged commit 7bbe60f into main Nov 13, 2024
31 of 32 checks passed
@graphite-app graphite-app bot deleted the fix_only_use_paymaster_for_sophon_testnet_chain branch November 13, 2024 20:39
@vercel vercel bot temporarily deployed to Production – wallet-ui November 13, 2024 20:39 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 13, 2024 20:39 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 13, 2024 20:39 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@MananTank MananTank Awaiting requested review from MananTank

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquim-verges @jnsdls